Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo plugin #630

Open
wants to merge 13 commits into
base: roots-manuva
Choose a base branch
from
Open

Conversation

apaleslimghost
Copy link
Member

@apaleslimghost apaleslimghost commented Apr 24, 2024

pretty barebones right now, but it works!

  • just exports a task. if you want to run commands in your workspace packages, run that task at the toplevel, and it will run the same command in the workspace

    example

    .toolkitrc.yml

    commands:
      test:local: WorkspaceCommand

    packages/something/.toolkitrc.yml

    commands:
      test:local: Cypress # only needed in this package

    npx dotcom-tool-kit test:local in the root runs test:local in packages/something, which runs Cypress

  • refactors some stuff in the core to expose some internals needed for the monorepo taskWIP: make tool kit config loading agnostic of CWD #709

  • rudimentary error handling and logging, i would like to go through this with a fine tooth comb when i get chance

opened as a draft as i want to discuss whether it's worth merging in its current state or if it needs fleshing out a bit more

still to do:

  • proper error handling and logging
  • tests!
  • try migrating cp-content-pipeline to it 😬
  • filtering which workspace packages to run command on?
    • glob vs regex?
  • documentation (plugin + high level monorepo workflow overview)

@apaleslimghost apaleslimghost force-pushed the monorepos-monorepos-monorepos branch from a617d77 to 456ce34 Compare May 9, 2024 08:58
Copy link
Contributor

@ivomurrell ivomurrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm very happy that this is so simple! though the proof is in the cp-content-pipeline pudding...

plugins/monorepo/package.json Show resolved Hide resolved
@apaleslimghost apaleslimghost force-pushed the monorepos-monorepos-monorepos branch 2 times, most recently from b451dfb to 32c9c65 Compare July 25, 2024 11:30
@apaleslimghost apaleslimghost changed the base branch from next to create-plugin-fixes July 25, 2024 13:41
Base automatically changed from create-plugin-fixes to next July 25, 2024 13:42
@apaleslimghost apaleslimghost changed the base branch from next to task-context July 25, 2024 13:47
@apaleslimghost apaleslimghost force-pushed the monorepos-monorepos-monorepos branch 2 times, most recently from 0e0ae70 to 5a89031 Compare July 25, 2024 16:02
@apaleslimghost apaleslimghost changed the base branch from task-context to split-config-loading July 25, 2024 16:03
@apaleslimghost apaleslimghost marked this pull request as ready for review October 1, 2024 13:13
@apaleslimghost apaleslimghost requested a review from a team as a code owner October 1, 2024 13:13
Base automatically changed from split-config-loading to main October 1, 2024 14:55
@apaleslimghost apaleslimghost changed the base branch from main to roots-manuva November 8, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants